Make logging persistent by logging to files on host #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a.log see rotating file handler doc: https://docs.python.org/3/library/logging.handlers.html#rotatingfilehandler
|
I just added another handler to write warning error and critical logs to another file to ease readibility of tehse errors |
ZynoXelek
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does it work:
share a volume with the host
host folder path configurable through LOG_FOLDER, container folder is /opt/root-pythia/logs
write to
RootPythia.logfile inside this folder, created if it doesn't exist, append to it if it existsthe same formatter than for the usual stream logging is uses (the discordpy one)
it uses a
RotatingFileHandlerto avoid log file to grow indefinitelythe max size of a log file is configurable through LOG_FILE_SIZE_MAX in bytes, default is 10MB
once the file has reached its max size it is renamed
RootPythia.log.1silently by the handler which continues to wirte to a brand newRootPythia.logfilethe number of old log file kept is configurable through LOG_FILES_NUMBER
everything has been tested